Misc improvements #162
Merged
Misc improvements #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
approved these changes
Aug 29, 2023
| String rbsType = "Array[" + member.getProperty("rbsType").get() + "]"; | ||
| String yardType = "Array<" + member.getProperty("yardType").get() + ">"; | ||
| return createSymbolBuilder(shape, getDefaultShapeName(shape, "List__"), rbsType, yardType, moduleName) | ||
| String rbsType = "::Array[" + member.getProperty("rbsType").get() + "]"; |
There was a problem hiding this comment.
Out of scope of this PR - but I think related to my comment from previous PR - I think maybe we shoudl define a RubyType class and create instances for things like Array. that will know how to do the doc types, rbs, contarints, ect.... I think this applies here and in the middleware and possibly in other places as well.
There was a problem hiding this comment.
I'm not sure what that would look like... But yeah we can potentially do that outside this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBS struct members
Refactor interceptor apply out of interceptor list
Rename yardType to docType
Extra RBS in hearth + some minor tweaks
other minor stuff.