Fix failing tests, running tests on Mac #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suite3 was failing because it relied on what the server wrote to .smithy.lsp.log, which has to be enabled through the setting 'smithyLsp.logToFile'. suite4 test workspace had updated smithy trait package dependency versions, but the assertions weren't updated to match. Side note: I think its fine to keep these tests at smithy 1.40, since the extension/server should work fine with whatever smithy version. Also needed the same setting as suite3. Also had to update a dependency so tests could successfully run on Mac.
hpmellema
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suite3 was failing because it relied on what the server wrote to .smithy.lsp.log, which has to be enabled through the setting 'smithyLsp.logToFile'.
suite4 test workspace had updated smithy trait package dependency versions, but the assertions weren't updated to match. Side note: I think its fine to keep these tests at smithy 1.40, since the extension/server should work fine with whatever smithy version.
Also had to update a dependency so tests could successfully run on Mac.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.