Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocu-472] basic smithyctl boilerplate + small fixes #707

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Jan 16, 2025

Re-opened from #705


  • Adding boilerplate for smithyctl commands. Will open another PR shortly implementing packaging.
  • Fixing a small bug on V1 Types parsing. Also moving exported code in pkg
  • Making sure that we can test every single go test file on CI - some were being skipped and now it's fixed. Opened https://linear.app/smithy/issue/OCU-482/make-sure-git-cloner-integration-test-works-on-ci to tackle an issue that I found on CI with a test. I spent some time on it but it would be better for me to focus on what matters more right now. I have an action to work on this when I have more time.
  • Fixed an issue with the bandit scanner not building correctly due to wrong import
  • Refreshed all dependencies
  • Make sure that every single test in the repo is executed and passes

@andream16 andream16 force-pushed the andream16/OCU-472/basic-smithyctl-boilerplate-and-cleanup branch 4 times, most recently from 562e624 to 7bdf446 Compare January 16, 2025 16:58
@andream16 andream16 force-pushed the andream16/OCU-472/basic-smithyctl-boilerplate-and-cleanup branch from 7bdf446 to 123c90b Compare January 16, 2025 17:10
@andream16 andream16 force-pushed the andream16/OCU-472/basic-smithyctl-boilerplate-and-cleanup branch from 123c90b to 73c19fd Compare January 16, 2025 17:21
@andream16 andream16 changed the title Andream16/ocu 472/basic smithyctl boilerplate and cleanup [ocu-472] basic smithyctl boilerplate + small fixes Jan 16, 2025
pkg/types/v1/parameter.go Show resolved Hide resolved
tools.go Show resolved Hide resolved
smithyctl/pkg/command/command.go Show resolved Hide resolved
new-components/scanners/bandit/cmd/main.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@andream16 andream16 marked this pull request as ready for review January 16, 2025 17:39
@andream16 andream16 self-assigned this Jan 16, 2025
@andream16 andream16 force-pushed the andream16/OCU-472/basic-smithyctl-boilerplate-and-cleanup branch from 73c19fd to 1b15558 Compare January 17, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants