Remove duplicate spaces in the calc description #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we be avoiding the double spaces in the first place rather than using a regex to remove them afterwards? |
|
That's probably a better solution, but I didn't want to touch as much of the existing code when I did this commit. I can look at it again and figure out something that would avoid double spaces while constructing the calc description. |
|
Found that the issue behind the double space problem was that the descriptors for the Flower Gift boosts, Battery boosts, Power Spot boosts, and the switch boost (for Pursuit) had spaces on either side of the message when it should have only been on one side. This is now standardized with the other descriptors, and a test has been written for this. |
lawauditswe
approved these changes
Sep 20, 2023
|
Thanks! |
ForwardFeed
pushed a commit
to ForwardFeed/damage-calc
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/pok%C3%A9mon-showdown-damage-calculator.3593546/post-9724268
Before (first line) vs after (second line) with double spaces highlighted.
