Mold Breaker shouldn't remove abilities that don't affect direct damage #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://www.smogon.com/forums/threads/pok%C3%A9mon-showdown-damage-calculator.3593546/post-10239710
Before:
0 SpA Mold Breaker Ampharos-Mega Dragon Pulse vs. 252 HP / 252+ SpD Iron Treads: 63-75 (16.4 - 19.5%) -- possible 8HKO
(Activate Electric Terrain)
0 SpA Mold Breaker Ampharos-Mega Dragon Pulse vs. 252 HP / 252+ SpD Iron Treads: 63-75 (16.4 - 19.5%) -- possible 8HKO
After:
0 SpA Mold Breaker Ampharos-Mega Dragon Pulse vs. 252 HP / 252+ SpD Iron Treads: 63-75 (16.4 - 19.5%) -- possible 8HKO
(Activate Electric Terrain)
0 SpA Mold Breaker Ampharos-Mega Dragon Pulse vs. 252 HP / 252+ SpD Quark Drive Iron Treads: 49-58 (12.7 - 15.1%) -- possibly the worst move ever
I think that if we used
@pkmn/dataand@pkmn/dex, then this code (as well as other pieces of code) can be cleaned up more easily, but that isn't taking into account any performance penalty and bundle size increase that may occur because of it.