Skip to content

Commit

Permalink
Merge pull request #117 from smswithoutborders/feature/grpc_api
Browse files Browse the repository at this point in the history
fix: update ListEntityStoredTokenResponse to ListEntityStoredTokensRe…
  • Loading branch information
PromiseFru authored Jul 8, 2024
2 parents dfc94de + 542b172 commit 779775c
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 2 deletions.
2 changes: 1 addition & 1 deletion grpc_internal_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def intercept(self, method, request_or_iterator, context, method_name):
str(context.code()).split(".")[1],
)
else:
self.logger.error(
self.logger.info(
'%s - - [%s] "%s %s" %s -',
context.peer(),
datetime.now().strftime("%B %d, %Y %H:%M:%S"),
Expand Down
20 changes: 20 additions & 0 deletions protos/v1/vault.proto
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,24 @@ message ResetPasswordResponse {
int32 next_attempt_timestamp = 6;
}

// Request message for updating an entity's password.
message UpdateEntityPasswordRequest {
// The long-lived token of the authenticated entity.
string long_lived_token = 1;
// The old password of the entity.
string old_password = 2;
// The new password of the entity.
string new_password = 3;
}

// Response message for updating an entity's password.
message UpdateEntityPasswordResponse {
// A response message.
string message = 1;
// Indicates whether the operation was successful.
bool success = 2;
}

// Service for managing entities.
service Entity {
// Creates an entity.
Expand All @@ -257,6 +275,8 @@ service Entity {
rpc DeleteEntity(DeleteEntityRequest) returns (DeleteEntityResponse);
// Resets an entity's password
rpc ResetPassword(ResetPasswordRequest) returns (ResetPasswordResponse);
// Updates an entity's password.
rpc UpdateEntityPassword(UpdateEntityPasswordRequest) returns (UpdateEntityPasswordResponse);
}

// Service for managing entities internally.
Expand Down
7 changes: 6 additions & 1 deletion src/grpc_entity_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def validate_fields():
def ListEntityStoredTokens(self, request, context):
"""Handles listing an entity's stored tokens."""

response = vault_pb2.ListEntityStoredTokenResponse
response = vault_pb2.ListEntityStoredTokensResponse

try:
invalid_fields_response = validate_request_fields(
Expand Down Expand Up @@ -769,3 +769,8 @@ def validate_fields():
user_msg="Oops! Something went wrong. Please try again later.",
_type="UNKNOWN",
)

def UpdateEntityPassword(self, request, context):
"""Handles changing an entity's password."""

response = vault_pb2.UpdateEntityPasswordResponse

0 comments on commit 779775c

Please sign in to comment.