Call for testing ruff

[github-actions]

A new version (0.7.2) of ruff was just pushed to the latest/candidate channel in the snap store. The following revisions are available.

CPU Architecture	Revision
amd64	1169
arm64	1170
armhf	1172
ppc64el	1171
s390x	1168

Automated testing

If configured, the snap will be installed in a VM, and any test results or screenshots will be posted to this issue as a comment shortly.

How to test it manually

1. Stop the application if it was already running
2. Upgrade to this version by running

snap refresh ruff --channel latest/candidate

3. Start the app and test it out.
4. Finally, add a comment below explaining whether this app is working, and include the output of the following command.

snap version; lscpu | grep Architecture; snap info ruff | grep installed

How to release it

Maintainers can promote this to stable by commenting /promote <rev>[,<rev>] latest/stable [done].

For example

• To promote a single revision, run /promote <rev> latest/stable
• To promote multiple revisions, run /promote <rev>,<rev> latest/stable
• To promote a revision and close the issue, run /promote <rev>,<rev> latest/stable done

You can promote all revisions that were just built with:

/promote 1169,1170,1172,1171,1168 latest/stable done

[github-actions]

Automated testing success.

Full logs are available at https://github.com/snapcrafters/ruff/actions/runs/11684626974. The first 100, and last 100 lines of the log are displayed in the Summary below.

Logs

ruff 0.7.2 (11c3b52fd 2024-11-01)
::endgroup::
::group::Help
Ruff: An extremely fast Python linter and code formatter.

Usage: ruff [OPTIONS] <COMMAND>

Commands:
check    Run Ruff on the given files or directories
rule     Explain a rule (or all rules)
config   List or describe the available configuration options
linter   List all supported upstream linters
clean    Clear any caches in the current directory and any subdirectories
format   Run the Ruff formatter on the given files or directories
server   Run the language server
analyze  Run analysis over Python source code
version  Display Ruff's version
help     Print this message or the help of the given subcommand(s)

Options:
-h, --help     Print help
-V, --version  Print version

Log levels:
-v, --verbose  Enable verbose logging
-q, --quiet    Print diagnostics, but nothing else
-s, --silent   Disable all logging (but still exit with status code "1" upon detecting
               diagnostics)

Global options:
    --config <CONFIG_OPTION>  Either a path to a TOML configuration file (`pyproject.toml` or
                              `ruff.toml`), or a TOML `<KEY> = <VALUE>` pair (such as you might
                              find in a `ruff.toml` configuration file) overriding a specific
                              configuration option. Overrides of individual settings using this
                              option always take precedence over all configuration files,
                              including configuration files that were also specified using
                              `--config`
    --isolated                Ignore all configuration files

For help with a specific command, see: `ruff help <command>`.
::endgroup::
::group::Rules:
# airflow-variable-name-task-id-mismatch (AIR001)

Derived from the **Airflow** linter.

## What it does
Checks that the task variable name matches the `task_id` value for
Airflow Operators.

## Why is this bad?
When initializing an Airflow Operator, for consistency, the variable
name should match the `task_id` value. This makes it easier to
follow the flow of the DAG.

## Example
```python
from airflow.operators import PythonOperator


incorrect_name = PythonOperator(task_id="my_task")

Use instead:

from airflow.operators import PythonOperator


my_task = PythonOperator(task_id="my_task")

commented-out-code (ERA001)

Derived from the eradicate linter.

What it does

Checks for commented-out Python code.

Why is this bad?

Commented-out code is dead code, and is often included inadvertently.
It should be removed.

Known problems

Prone to false positives when checking comments that resemble Python code,
but are not actually Python code (#4845).

Example

# print("Hello, world!")

Options

• lint.task-tags

fast-api-redundant-response-model (FAST001)

Derived from the FastAPI linter.

(Logs truncated. See full logs at: https://github.com/snapcrafters/ruff/actions/runs/11684626974)

|                      ^^^^^^^^ F841

334 |
335 | if fn_info.is_generator:
|
= help: Remove assignment to unused variable ret_type

mypyc/irbuild/function.py:420:14: F841 Local variable func_reg is assigned to but never used
|
418 | class_ir = builder.mapper.type_to_ir[cdef.info]
419 | sig = builder.mapper.fdef_to_sig(fdef, builder.options.strict_dunders_typing)
420 | func_ir, func_reg = gen_func_item(builder, fdef, name, sig, cdef)
| ^^^^^^^^ F841
421 | builder.functions.append(func_ir)
|
= help: Remove assignment to unused variable func_reg

mypyc/irbuild/function.py:957:29: F841 Local variable fn_info is assigned to but never used
|
955 | ret_val = builder.builder.call(callable_class_decl, args, arg_kinds, arg_names, line)
956 | builder.add(Return(ret_val))
957 | arg_regs, _, blocks, _, fn_info = builder.leave()
| ^^^^^^^ F841
958 | return FuncIR(decl, arg_regs, blocks)
|
= help: Remove assignment to unused variable fn_info

mypyc/irbuild/function.py:1065:22: F841 Local variable ret_type is assigned to but never used
|
1063 | else:
1064 | builder.add(Unreachable())
1065 | args, _, blocks, ret_type, fn_info = builder.leave()
| ^^^^^^^^ F841
1066 | return FuncIR(func_decl, args, blocks)
|
= help: Remove assignment to unused variable ret_type

mypyc/irbuild/function.py:1065:32: F841 Local variable fn_info is assigned to but never used
|
1063 | else:
1064 | builder.add(Unreachable())
1065 | args, _, blocks, ret_type, fn_info = builder.leave()
| ^^^^^^^ F841
1066 | return FuncIR(func_decl, args, blocks)
|
= help: Remove assignment to unused variable fn_info

mypyc/irbuild/function.py:1085:22: F841 Local variable ret_type is assigned to but never used
|
1083 | builder.add(SetAttr(self_reg, attr_name, value_reg, -1))
1084 | builder.add(Return(builder.none()))
1085 | args, _, blocks, ret_type, fn_info = builder.leave()
| ^^^^^^^^ F841
1086 | return FuncIR(func_decl, args, blocks)
|
= help: Remove assignment to unused variable ret_type

mypyc/irbuild/function.py:1085:32: F841 Local variable fn_info is assigned to but never used
|
1083 | builder.add(SetAttr(self_reg, attr_name, value_reg, -1))
1084 | builder.add(Return(builder.none()))
1085 | args, _, blocks, ret_type, fn_info = builder.leave()
| ^^^^^^^ F841
1086 | return FuncIR(func_decl, args, blocks)
|
= help: Remove assignment to unused variable fn_info

mypyc/irbuild/main.py:146:22: F841 Local variable ret_type is assigned to but never used
|
145 | # Generate special function representing module top level.
146 | args, _, blocks, ret_type, _ = builder.leave()
| ^^^^^^^^ F841
147 | sig = FuncSignature([], none_rprimitive)
148 | func_ir = FuncIR(
|
= help: Remove assignment to unused variable ret_type

Found 32 errors (2 fixed, 30 remaining).
warning: The following rule may cause conflicts when used with the formatter: ISC001. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the select or extend-select configuration, or adding it to the ignore configuration.
8 files reformatted, 304 files left unchanged
warning: The following rule may cause conflicts when used with the formatter: ISC001. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the select or extend-select configuration, or adding it to the ignore configuration.
51 files reformatted, 261 files left unchanged
::endgroup::

::group::Repository: https://github.com/tiangolo/fastapi
Cloning into 'ruff-snap-test-TPI7eH29'...
All checks passed!
docs_src/sql_databases_peewee/sql_app/database.py:7:43: B039 Do not use mutable data structures for ContextVar defaults
|
5 | DATABASE_NAME = "test.db"
6 | db_state_default = {"closed": None, "conn": None, "ctx": None, "transactions": None}
7 | db_state = ContextVar("db_state", default=db_state_default.copy())
| ^^^^^^^^^^^^^^^^^^^^^^^ B039
|
= help: Replace with None; initialize with `.set()``

Found 4 errors (3 fixed, 1 remaining).
1283 files left unchanged
197 files reformatted, 1086 files left unchanged
::endgroup::

</details>