Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3 #114

Closed
snarfed opened this issue Jul 25, 2017 · 10 comments
Closed

support python 3 #114

snarfed opened this issue Jul 25, 2017 · 10 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Jul 25, 2017

i believe the long pole here is a few indirect dependencies via oauth-dropins that don't support python 3. google-api-python-client? others? need to audit and come up with the complete list.

@kylewm
Copy link
Contributor

kylewm commented Jul 27, 2017

google-api-python-client claims to support python 3!

@snarfed
Copy link
Owner Author

snarfed commented Jul 27, 2017

ooh! now if only they'd cut a release. :P googleapis/google-api-python-client#421

@snarfed
Copy link
Owner Author

snarfed commented Aug 25, 2017

https://caniusepython3.com/project/granary claims we're only blocked on gdata and python-tumblpy.

@snarfed
Copy link
Owner Author

snarfed commented Aug 25, 2017

...and tumblpy actually claims it supports python 3!

gdata definitely does not: google/gdata-python-client#29 (also google/gdata-python-client#47)

here's a gdata fork that supposedly does: https://github.com/dvska/gdata-python3

@snarfed
Copy link
Owner Author

snarfed commented Aug 31, 2017

also, app engine standard is still python 2 only (and will probably always be), so i'll need to maintain python 2 compatibility. six and future are the two libraries for that i'm familiar with. not sure which is better.

@snarfed
Copy link
Owner Author

snarfed commented Aug 31, 2017

hrm, mox is also python 2 only: glasser/pymox#45

here's a fork that attempts python 3 compatibility:
https://github.com/e0ne/pymox/tree/python3
https://pypi.python.org/pypi/mox3

assuming i use six or future, i could install both mox versions and test with both python versions, respectively.

otherwise i could theoretically ship python 3 support while keeping the tests python 2 only, but that's not ideal.

@snarfed
Copy link
Owner Author

snarfed commented Jan 7, 2018

@snarfed snarfed added the now label Jan 9, 2018
snarfed added a commit that referenced this issue Jan 15, 2018
@snarfed
Copy link
Owner Author

snarfed commented Jan 16, 2018

note to myself, how i set up the virtualenv to use my local source clone of python-future:

cd l
foreach d (_dummy_thread _markupbase _thread builtins copyreg future html http libfuturize libpasteurize past queue reprlib socketserver tkinter winreg xmlrpc)
  ln -s ~/src/python-future/src/$d
end

snarfed added a commit that referenced this issue Jan 16, 2018
snarfed added a commit that referenced this issue Feb 4, 2018
snarfed added a commit that referenced this issue Mar 12, 2018
@snarfed
Copy link
Owner Author

snarfed commented Mar 18, 2018

getting close! the python3 branches of granary, bridgy, oauth-dropins, and webutil are all fully migrated to 2/3 compatible and all unit tests pass.

snarfed added a commit that referenced this issue Mar 18, 2018
@snarfed
Copy link
Owner Author

snarfed commented Mar 22, 2018

woo, done! and merged into master. will be released in v1.12.

@snarfed snarfed closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants