Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use intent sharing PkPass instead of hardcoded Google Wallet #13

Open
TheOneWithTheBraid opened this issue Sep 28, 2023 · 3 comments
Open

Comments

@TheOneWithTheBraid
Copy link

The current implementation uses GoogleWalletClient.savePass. It is therefore only possible to use this plugin with Google Wallet. If users chose to use another wallet application or even run on an Android Device without the Google Service Framework available, this plugin obviously won't work at all.

I would hence propose to additionally add the option to use the "traditional" Android way and share the pass (either as transit JSON or as PkPass) as an INTENT a compatible application can receive. For this use case, a PkPass file is likely more eligible than raw transit JSON.

Steps to reproduce :

  • use a device without GSF
  • open SNCF Connect
  • open a ticket details page
  • you won't see the Add to wallet button since the GoogleWalletClient.getPayApiAvailabilityStatus will return unavailable
  • be sad you can't import your TGV journey into your wallet since you don't use Google 😢
@Tiska
Copy link
Contributor

Tiska commented Dec 5, 2023

Hello, have you examples of other wallets you are using ? The name of this plugin is flutter_google_wallet so indeed, this is not here about the wallet feature of sncf connect but the flutter plugin to access the google wallet

@TheOneWithTheBraid
Copy link
Author

In my case I'm using fWallet, but there are other PkPass applications too : https://search.f-droid.org/?q=pkpass. Unlike a deeplink to Google's Android APIs, using PkPass (which at least SNCF connects also supports, though on Apple devices only), PkPass files enable users to use the Wallet implementation of their choice.

@Tiska
Copy link
Contributor

Tiska commented Dec 5, 2023

That's the way Google Wallet works, and that's the main audience of our app. But we could give also the pk pass, maybe with another button. Do you know if there is a simple way to detect the presence of fWallet on a device ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants