Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to share attachments from other applications #18

Open
distefam opened this issue Feb 25, 2021 · 1 comment · May be fixed by #56
Open

Unable to share attachments from other applications #18

distefam opened this issue Feb 25, 2021 · 1 comment · May be fixed by #56
Labels
bug Something isn't working upstream This issue should be fixed in the upstream project ux UI/UX issue

Comments

@distefam
Copy link
Collaborator

Describe the bug
Sharing attachments via other applications opens an unusable share sheet.

To Reproduce
Steps to reproduce the behavior:

  1. Go to photos
  2. Share a photo
  3. Select Snikket as a destination application
  4. Observe empty share sheet

Expected behavior
Share sheet should allow user to select at least one contact with whom to share the given photo.

Screenshots
Here is a short screen recording of the observed behavior:
https://user-images.githubusercontent.com/65571/109175492-d84f5200-7753-11eb-9f35-a31a5eb345c1.mp4
@distefam distefam added bug Something isn't working ux UI/UX issue labels Feb 25, 2021
@mimi89999 mimi89999 added the upstream This issue should be fixed in the upstream project label Feb 25, 2021
@zeen zeen added this to the Initial public release milestone Mar 1, 2021
@mwild1 mwild1 unassigned zeen Aug 21, 2021
@mwild1 mwild1 linked a pull request Aug 22, 2021 that will close this issue
Draft
@mwild1 mwild1 mentioned this issue Aug 24, 2021
Closed
@mwild1
Copy link
Member

mwild1 commented Aug 24, 2021

This issue is currently on hold. There is a PR #56 to fix the empty accounts list. However that fix reveals other issues - notably that text/attachments shared this way are sent unencrypted.

The share extension runs as a separate process, and if the main process is running, it may not be able to reliably read/write the database that stores the OMEMO sessions. There are plans to fix this upstream (Siskin 7.0).

For now we will disable sharing from other apps (#64) and revisit it further down the road.

@mwild1 mwild1 removed this from the Initial public release milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream This issue should be fixed in the upstream project ux UI/UX issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed sharing to Snikket snikket-im/snikket-ios
5 participants
@mwild1 @distefam @zeen @khaliddd @mimi89999