Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfs not created #103

Closed
plastikfan opened this issue Jan 6, 2024 · 0 comments · Fixed by #104
Closed

vfs not created #103

plastikfan opened this issue Jan 6, 2024 · 0 comments · Fixed by #104
Assignees
Labels
bug Something isn't working

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Jan 6, 2024

need to define e2e test with nothing mocked out, so that we can check the app works outside the confines of a test.

 ✘ plastikfan@Hydra   λ   main  pixa shrink ~/dev/test/pics --profile blur --sample
===> 💥💥💥 USING DUMMY EXECUTOR !!!!
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x128 pc=0x14a1b6f]

goroutine 1 [running]:
github.com/snivilised/pixa/src/app/command.(*MsAdvancedConfigReader).Read(0x8?, {0x0, 0x0})
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/command/config-readers.go:73 +0x2f
github.com/snivilised/pixa/src/app/command.(*Bootstrap).viper(0xc00020b180)
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/command/bootstrap.go:264 +0x114
github.com/snivilised/pixa/src/app/command.(*Bootstrap).buildShrinkCommand(0xc00020b180, 0xc00018caf8)
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/command/shrink-cmd.go:342 +0x716
github.com/snivilised/pixa/src/app/command.(*Bootstrap).Root(0xc00020b180, {0x0, 0x0, 0x1ae7c78?})
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/command/bootstrap.go:191 +0x638
github.com/snivilised/pixa/src/app/command.Execute()
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/command/root-cmd.go:27 +0x26
main.main()
	/Users/plastikfan/dev/github/snivilised/pixa/src/app/main/main.go:10 +0xf
 ✘ plastikfan@Hydra   λ   main

Also, there is mix up on ConfigureOptionsInfo which has a redundant Viper field which is duplicated (probably just leftover from a previous refactoring but should have been removed but wasn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant