Use SPDX short code for license in Pyproject.toml #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the license for this project on Pypi1 lists two licenses (BSD License, Other/Proprietary License (BSD)) when it should probably only list the first.
Software supply chain tools like Sonatype2 rely on these fields being set correctly when determining whether to block or allow packages to be installed. Because a license of type Other/Proprietary is being shown on Pypi, Sonatype is restricting access to this package for my organization even though it is BSD licensed and valid for commercial use. I believe this is because the
pyproject.toml
license attribute is set to an unrecognized string and thus mapped to Other/Proprietary.This PR attempts to fix the issue by instead specifying a valid SPDX3 short code as specified in the Poetry docs4.
Footnotes
https://pypi.org/project/django-auth-adfs/ ↩
https://www.sonatype.com ↩
https://spdx.org/licenses/BSD-2-Clause.html ↩
https://python-poetry.org/docs/pyproject/ ↩