Support groups query customization #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _ms_request conslidates the error handling logic into a single method. This should make overriding methods easier for end users.
JonasKs
reviewed
Oct 18, 2024
vidhuUC
reviewed
Oct 23, 2024
|
|
||
| logger.debug("Getting access token at: %s", provider_config.token_endpoint) | ||
| response = provider_config.session.post(provider_config.token_endpoint, data, timeout=settings.TIMEOUT) | ||
| def _ms_request(self, action, url, data=None, **kwargs): |
There was a problem hiding this comment.
I tried running this code, there no handling for params and headers in request
There was a problem hiding this comment.
Can you share your code in a gist or a link to your repo with the change?
There was a problem hiding this comment.
Can you share your code in a gist or a link to your repo with the change?
There was a problem hiding this comment.
That doesn't appear to be using this change.
JonasKs
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #274
Fixes #272