Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver test to read parameters file #1245

Closed
wants to merge 1 commit into from

Conversation

rickr-sigma
Copy link

Description

The README states to use a parameters.json file for the test connection configuration. This works fine when running make test, but if you want to run a test in an ide or individual ones this file is ignored and you need to manually set the env vars.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@rickr-sigma rickr-sigma requested a review from a team as a code owner November 16, 2024 01:28
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-pfus
Copy link
Collaborator

Hi @rickr-sigma ! Thanks for expressing your interest in that area. Unfortunately, we don't want to change it. Readme states that this file is used for make test and it is fine. It is the same way as it works in all our drivers. Sorry for the inconvenience that it makes for you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@rickr-sigma rickr-sigma deleted the rr/useparam branch January 6, 2025 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants