Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1769605 Add timeout to cloud storage #1272

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 10, 2024

Description

SNOW-1769605 Added timeout configuration when calling cloud storage

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1769605-csp-timeout branch 4 times, most recently from d99b023 to 5d661e9 Compare December 11, 2024 10:21
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1769605-csp-timeout branch from 5d661e9 to cfb818b Compare December 11, 2024 10:28
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 11, 2024 11:20
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 11, 2024 11:20
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 89.92806% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (f8baf23) to head (eec0e2b).

Files with missing lines Patch % Lines
gcs_storage_client.go 85.71% 6 Missing ⚠️
file_transfer_agent.go 70.58% 5 Missing ⚠️
dsn.go 81.81% 2 Missing ⚠️
s3_storage_client.go 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
+ Coverage   82.20%   82.22%   +0.01%     
==========================================
  Files          55       55              
  Lines       13484    13529      +45     
==========================================
+ Hits        11085    11124      +39     
- Misses       2399     2405       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

azure_storage_client.go Show resolved Hide resolved
file_transfer_agent.go Show resolved Hide resolved
azure_storage_client.go Outdated Show resolved Hide resolved
dsn.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1769605-csp-timeout branch from eec0e2b to 4c31de5 Compare December 16, 2024 10:42
@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) December 16, 2024 12:10
@sfc-gh-pfus sfc-gh-pfus merged commit 45b3d45 into master Dec 16, 2024
35 of 37 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1769605-csp-timeout branch December 16, 2024 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants