Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1854661 Detect JSON response in Arrow batches mode and return error #1277

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 13, 2024

Description

SNOW-1854661 Detect JSON response in Arrow batches mode and return error instead of panic.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 13, 2024 12:55
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 13, 2024 12:55
@sfc-gh-pfus sfc-gh-pfus changed the title SNOW-1854657 Detect JSON response in Arrow batches mode and return error SNOW-1854661 Detect JSON response in Arrow batches mode and return error Dec 13, 2024
chunk_test.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1854657-detect-json-in-arrow-batches branch from df937bf to 5df709e Compare December 16, 2024 09:18
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (f8baf23) to head (5df709e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   82.20%   82.20%   -0.01%     
==========================================
  Files          55       55              
  Lines       13484    13492       +8     
==========================================
+ Hits        11085    11091       +6     
- Misses       2399     2401       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus merged commit 4f89e5b into master Dec 16, 2024
39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1854657-detect-json-in-arrow-batches branch December 16, 2024 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants