Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-894815 Fix access to params from htap #934

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Oct 16, 2023

Description

Fixes concurrent access to params from HTAP calls.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 16, 2023 07:49
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #934 (102e8d5) into master (dfb1c18) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   83.23%   83.24%   +0.01%     
==========================================
  Files          49       49              
  Lines        9287     9293       +6     
==========================================
+ Hits         7730     7736       +6     
  Misses       1557     1557              
Files Coverage Δ
encrypt_util.go 73.73% <100.00%> (+0.36%) ⬆️
htap.go 98.00% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-pfus sfc-gh-pfus merged commit 5218d7a into master Oct 16, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-894815-fix-htap branch October 16, 2023 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants