Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-870356: Increase code coverage on CodeCov #921

Merged
merged 27 commits into from
Oct 30, 2023
Merged

SNOW-870356: Increase code coverage on CodeCov #921

merged 27 commits into from
Oct 30, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 4, 2023 •
edited
Loading

Description

Issue 685: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/685

Added more tests to increase code coverage.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #921 (208f2dd) into master (8479309) will increase coverage by 0.73%.
Report is 2 commits behind head on master.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   83.06%   83.80%   +0.73%     
==========================================
  Files          50       50              
  Lines        9556     9556              
==========================================
+ Hits         7938     8008      +70     
+ Misses       1618     1548      -70
Files Coverage Δ
authokta.go 85.89% <100.00%> (+7.46%) ⬆️
errors.go 97.97% <100.00%> (+0.10%) ⬆️
client_configuration.go 88.37% <77.77%> (+3.75%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 23, 2023 17:12
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 23, 2023 17:12
sfc-gh-pfus
sfc-gh-pfus reviewed Oct 24, 2023
View reviewed changes
auth_test.go Outdated Show resolved Hide resolved
auth_test.go Outdated Show resolved Hide resolved
connection_util.go Outdated Show resolved Hide resolved
connection_util.go Outdated Show resolved Hide resolved
auth_test.go Outdated Show resolved Hide resolved
file_transfer_agent_test.go Show resolved Hide resolved
file_transfer_agent_test.go Outdated Show resolved Hide resolved
transaction_test.go Outdated Show resolved Hide resolved
transaction_test.go Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Oct 27, 2023
View reviewed changes
auth_test.go Outdated Show resolved Hide resolved
authokta_test.go Outdated Show resolved Hide resolved
authokta_test.go Outdated Show resolved Hide resolved
connection_util.go Outdated Show resolved Hide resolved
connector_test.go Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 1f9df02 into master Oct 30, 2023
23 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-870356-increase-coverage branch October 30, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jl @sfc-gh-pfus