Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster formula for snowcli installation #14

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Jan 26, 2024

Description:

Replace downloading and installing dependencies one by one with pip dependency resolver, plus experimentally remove unnecessary dependencies and installation commands.

Reasoning:

  • pip dependency resolver works faster than homebrew's resources strategy (at least for this case)
  • main reasoning behind the resources is to freeze versions of all packages used by app. Our pyproject.toml is well defined, so versions of the dependencies should be frozen there

Risks:

  • additional assumption that "our pip command works well and has well-defined, frozen dependencies"
  • homebrew core developers might be not happy, as they prefer enclosing dependencies as resources

For testing:

brew tap sfc-gh-pczajka/homebrew-snowcli
brew install snowcli
snow --help     # should work

@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as ready for review January 29, 2024 17:22
@sfc-gh-pczajka sfc-gh-pczajka merged commit 395004d into main Jan 30, 2024
1 check passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-1004047-faster-brew-install branch January 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants