Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 fix #19

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Python 3.12 fix #19

merged 1 commit into from
Feb 26, 2024

Conversation

sfc-gh-astus
Copy link
Collaborator

No description provided.

sfc-gh-pjob
sfc-gh-pjob reviewed Feb 23, 2024
View reviewed changes
Formula/snowcli.tmpl.rb Outdated
"install", "snowflake-cli-labs=={{ version }}"
"-m", "ensurepip", "--upgrade"
venv.instance_variable_get(:@formula).system venv.instance_variable_get(:@venv_root)/"bin/python",
"-m", "pip", "install", "snowflake-cli-labs==2.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't use version, let's remove it from update.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should - update.py replaces {{ version }} from snowcli.tmpl.rb into actual version in snowcli.rb

Suggested change
"-m", "pip", "install", "snowflake-cli-labs==2.0.0"
"-m", "pip", "install", "snowflake-cli-labs=={{ version }}"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@sfc-gh-astus sfc-gh-astus merged commit e5e15b3 into main Feb 26, 2024
2 checks passed
@sfc-gh-astus sfc-gh-astus deleted the python-3.12-fix branch February 26, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-mraba sfc-gh-mraba Awaiting requested review from sfc-gh-mraba sfc-gh-mraba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-astus @sfc-gh-turbaszek @sfc-gh-pjob @sfc-gh-jsikorski @sfc-gh-pczajka