SNOW-910807: refactoring to reuse query context cache implementation in ODBC #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
SNOW-910807-qcc-reusable
branch
from
6c368f1 to
c5b70d9
Compare
ghost
force-pushed
the
SNOW-910807-qcc-reusable
branch
from
c5b70d9 to
060723c
Compare
sfc-gh-dprzybysz
approved these changes
Jan 9, 2024
|
e2e test with odbc code here https://github.com/snowflakedb/snowflake-odbc/tree/SNOW-910807-reuse-libsfc-qcc |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdk issue 643
Make the QCC implementation reusable.
To reuse the implementation in ODBC, similar as what's been done in ClientQueryContextCache, make a subclass of QueryContextCache and use picojson instead of cJSON.