Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-983098: add original source code for arrow 15.0.0 and boost 1.81.0 #675

Merged
1 commit merged into from
Mar 8, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2024

teamwork issue 780
Add original source code for arrow 15.0.0 and boost 1.81.0 which is the default boost version used by arrow 15.0.0 as well.
Removed source code for all other programing language in arrow:

  • c_glib
  • csharp
  • go
  • java
  • js
  • matlab
  • python
  • r
  • ruby
  • swift

Will have following PRs to update build scripts and docker image.

@ghost ghost self-requested a review as a code owner March 5, 2024 23:12
@ghost ghost requested a review from sfc-gh-dprzybysz March 5, 2024 23:13
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sfc-gh-ext-simba-hx
do you think we can also remove from the repo:

  • deps/arrow-15.0.0/dev
  • unused libraries from boost?

@ghost
Copy link
Author

ghost commented Mar 6, 2024

Thanks @sfc-gh-ext-simba-hx do you think we can also remove from the repo:

  • deps/arrow-15.0.0/dev
  • unused libraries from boost?

I think that's possible but we would need to do that each time updating arrow/boost. The main purpose of removing code for other programing languages from arrow is to prevent false alarm from there in security check that we had before.
If no special reason I would prefer to keep the updating process simple.

@ghost ghost merged commit 1b5b598 into master Mar 8, 2024
36 checks passed
@ghost ghost deleted the SNOW-983098-update-arrow-15.0.0-org branch March 8, 2024 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants