Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-928053: Upgrade to openssl3.0.11 and libcurl 8.4.0 #566

Merged
7 commits merged into from
Oct 26, 2023

Conversation

sfc-gh-ext-simba-jz
Copy link
Collaborator

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz commented Oct 6, 2023

Update openssl and curl for security concerns
upgrade dependencies openssl-3.0.11 and curl-8.4.0
patch snowflake change of ocsp on curl-8.1.2 to curl-8.4
update source and build versions of related build scripts

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz force-pushed the upgrade-openssl-curl branch 4 times, most recently from a92feef to 7c7699f Compare October 6, 2023 15:26
@ghost ghost force-pushed the upgrade-openssl-curl branch from 3d7ab3f to 96c96b0 Compare October 7, 2023 16:48
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz force-pushed the upgrade-openssl-curl branch 2 times, most recently from 6f10469 to a8b3131 Compare October 11, 2023 22:39
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz changed the title SNOW-928053: Upgrade to openssl3.0.11 and libcurl 8.3 SNOW-928053: Upgrade to openssl3.0.11 and libcurl 8.4.0 Oct 12, 2023
@ghost ghost force-pushed the upgrade-openssl-curl branch from fa2c65f to 164bafd Compare October 17, 2023 00:54
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz marked this pull request as ready for review October 19, 2023 01:10
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz requested a review from a team as a code owner October 19, 2023 01:10
@sfc-gh-igarish
Copy link
Collaborator

There are 5000+ files....

@sfc-gh-igarish
Copy link
Collaborator

@sfc-gh-ext-simba-jz could you please update description why we are upgrading?

@sfc-gh-ext-simba-jz
Copy link
Collaborator Author

Security concerns, I think. I was assigned the task in our OEM release 3.1.2 (during the release curl made a new release 8.4.0 from 8.3.0). The next monthly release should be 3.1.3, which make sense to include all those upgrades.

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it has 5000+ files and all are third party source code. So not reviewing files. If all merge gate pass then merge it.

@sfc-gh-ext-simba-jz
Copy link
Collaborator Author

Yes, there are over 5000 files, we replace openssl-3.0.9 and curl-8.1.2 with opessl-3.0.11 and curl-8.4.0. You don't need to pay attention to openssl because we don't change anything in openssl, just grab and use. We do modify curl for OCSP support, and I have patched everything what we have done in curl-8.1.2 to curl-8.4.0. So the actual change doesn't sound that scary.

@ghost ghost merged commit 7cde388 into master Oct 26, 2023
22 checks passed
@ghost ghost deleted the upgrade-openssl-curl branch October 26, 2023 12:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants