-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-928053: Upgrade to openssl3.0.11 and libcurl 8.4.0 #566
Conversation
a92feef
to
7c7699f
Compare
3d7ab3f
to
96c96b0
Compare
6f10469
to
a8b3131
Compare
2. update source versions and build versions respectively
…do not follow the checksrc doc, but break the debug build
fa2c65f
to
164bafd
Compare
There are 5000+ files.... |
@sfc-gh-ext-simba-jz could you please update description why we are upgrading? |
Security concerns, I think. I was assigned the task in our OEM release 3.1.2 (during the release curl made a new release 8.4.0 from 8.3.0). The next monthly release should be 3.1.3, which make sense to include all those upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it has 5000+ files and all are third party source code. So not reviewing files. If all merge gate pass then merge it.
Yes, there are over 5000 files, we replace openssl-3.0.9 and curl-8.1.2 with opessl-3.0.11 and curl-8.4.0. You don't need to pay attention to openssl because we don't change anything in openssl, just grab and use. We do modify curl for OCSP support, and I have patched everything what we have done in curl-8.1.2 to curl-8.4.0. So the actual change doesn't sound that scary. |
Update openssl and curl for security concerns
upgrade dependencies openssl-3.0.11 and curl-8.4.0
patch snowflake change of ocsp on curl-8.1.2 to curl-8.4
update source and build versions of related build scripts