Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-878098: Retry Strategy #571

Merged
5 commits merged into from
Oct 26, 2023
Merged

SNOW-878098: Retry Strategy #571

5 commits merged into from
Oct 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2023

sdk issu 581

  • add retry on http error code 429
  • new retry strategy of jittered exponential backoff, max retry count of 7 and retry time of 300 seconds apply on login/authenticator/token requests
  • add CLIENT_APP_ID, CLIENT_APP_VERSION in the header of login/authenticator/token requests

@ghost ghost self-requested a review as a code owner October 20, 2023 22:26
@ghost ghost requested a review from sfc-gh-igarish October 20, 2023 22:26
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost force-pushed the SNOW-878098-retry-strategy branch from 2e7e642 to 0d56185 Compare October 25, 2023 14:05
@ghost ghost force-pushed the SNOW-878098-retry-strategy branch from 0d56185 to 3d46d34 Compare October 25, 2023 16:19
@ghost ghost merged commit 5f5cf96 into master Oct 26, 2023
22 checks passed
@ghost ghost deleted the SNOW-878098-retry-strategy branch October 26, 2023 00:15
@ghost ghost mentioned this pull request Oct 27, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-igarish @sfc-gh-ext-simba-hx