Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ms-banned functions part2 #602

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

sfc-gh-ext-simba-jz
Copy link
Collaborator

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz commented Oct 31, 2023

getenv and strerror are two banned functions, the replacement allocate memory that need to be released by caller.

(in part1 we only put stubs for the replacement but no effective change)

This is 2nd part of solution of issue #708, SNOW-945768: Addressing Banned functions in ODBC driver

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz marked this pull request as ready for review November 2, 2023 15:40
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz requested a review from a team as a code owner November 2, 2023 15:40
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz merged commit c42a23b into master Nov 15, 2023
22 checks passed
@sfc-gh-ext-simba-jz sfc-gh-ext-simba-jz deleted the ms-banned-part2 branch November 15, 2023 22:09
@ghost ghost mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants