Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test case failures on jenkins Windows run #604

Merged
2 commits merged into from
Nov 3, 2023
Merged

fix test case failures on jenkins Windows run #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e393901
handle ERROR_PATH_NOT_FOUND from FindFirstFile
sfc-gh-ext-simba-hx Nov 2, 2023
0938f04
make copy from the original string just in case
sfc-gh-ext-simba-hx Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/FileMetadataInitializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ void Snowflake::Client::FileMetadataInitializer::populateSrcLocUploadMetadata(st
if (hFind == INVALID_HANDLE_VALUE)
{
DWORD dwError = GetLastError();
if (dwError == ERROR_NO_MORE_FILES || dwError == ERROR_FILE_NOT_FOUND)
if (dwError == ERROR_NO_MORE_FILES || dwError == ERROR_FILE_NOT_FOUND ||
dwError == ERROR_PATH_NOT_FOUND)
{
CXX_LOG_ERROR("No file matching pattern %s has been found. Error: %d",
sourceLocation.c_str(), dwError);
Expand Down
4 changes: 2 additions & 2 deletions include/snowflake/IStatementPutGet.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ class IStatementPutGet
// from system locale. No coversion by default.
virtual std::string UTF8ToPlatformString(const std::string& utf8_str)
{
return utf8_str;
return std::string(utf8_str);
}

virtual std::string platformStringToUTF8(const std::string& platform_str)
{
return platform_str;
return std::string(platform_str);
}

virtual ~IStatementPutGet()
Expand Down
Loading