SNOW-983100: libsnowflakeclient - banned functions in ODBC v3.1.2 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. replace strerror with strerror_r on Posix (with strerror_s on Windows already) 2. enhance getenv 2.1. thread safe in driver 2.2. allow reentrance with cloned value returned 3. strcpy/strncpy/strcat/strncat, implement bounds check according to spec of "secured" version 4. related updates 4.1. consistent API of sf_getenv and sf_strerror on all platforms 4.2. fix some memory leaks 4.3. relevant unit tests updates
|
New PR is made #659 |
|
If there is a newer PR we can close this draft |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1. thread safe in driver
2.2. allow reentrance with cloned value returned
4.1. consistent API of sf_getenv and sf_strerror on all platforms
4.2. fix some memory leaks
4.3. relevant unit tests updates