Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-983100: replace banned functions #659

Merged
4 commits merged into from
Feb 15, 2024
Merged

SNOW-983100: replace banned functions #659

4 commits merged into from
Feb 15, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2024 •
edited by ghost
Loading

sdk issue 782, replace banned function in security review

  • refactoring on sb_ functions mainly adding meaningful replacement on non-Windows
  • deprecate sf_getenv and sf_strerror and having replacement of sf_getenv_s and sf_strerror_s passing in buffer by caller.

@ghost ghost self-requested a review as a code owner February 6, 2024 17:28
@ghost ghost force-pushed the SNOW-983100-banned-function branch 4 times, most recently from 64aa0ea to 152a8d5 Compare February 6, 2024 22:39
@ghost ghost mentioned this pull request Feb 6, 2024
Closed
@ghost ghost force-pushed the SNOW-983100-banned-function branch 2 times, most recently from 7a3ef2b to 150ad41 Compare February 6, 2024 23:40
@ghost ghost requested a review from sfc-gh-dprzybysz February 7, 2024 00:17
@ghost ghost force-pushed the SNOW-983100-banned-function branch 3 times, most recently from 80d334e to 892abdd Compare February 7, 2024 00:52
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Feb 7, 2024
View reviewed changes
cpp/FileTransferAgent.cpp Outdated Show resolved Hide resolved
cpp/FileTransferAgent.cpp Outdated Show resolved Hide resolved
tests/test_unit_proxy.cpp Show resolved Hide resolved
include/snowflake/platform.h Outdated Show resolved Hide resolved
@ghost ghost force-pushed the SNOW-983100-banned-function branch from f296838 to 5313732 Compare February 7, 2024 19:26
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Feb 8, 2024
View reviewed changes
include/snowflake/sb_CRTFunctionSafe.h Outdated Show resolved Hide resolved
include/snowflake/sb_CRTFunctionSafe.h Outdated Show resolved Hide resolved
include/snowflake/sb_CRTFunctionSafe.h Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz
Copy link
Collaborator

@sfc-gh-ext-simba-hx SNOW-983110 is not the right id, it should be SNOW-983100

@ghost ghost changed the title SNOW-983110: replace banned functions SNOW-983100: replace banned functions Feb 8, 2024
@ghost ghost force-pushed the SNOW-983100-banned-function branch 2 times, most recently from 16fce9b to ea3d2d8 Compare February 14, 2024 00:50
@ghost ghost force-pushed the SNOW-983100-banned-function branch from ea3d2d8 to cbcaae5 Compare February 14, 2024 16:32
@ghost ghost force-pushed the SNOW-983100-banned-function branch from 6d8604c to 41199fc Compare February 14, 2024 18:42
@ghost ghost mentioned this pull request Feb 14, 2024
Merged
@ghost ghost merged commit 1e4eb43 into master Feb 15, 2024
34 checks passed
@ghost ghost deleted the SNOW-983100-banned-function branch February 15, 2024 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dprzybysz @sfc-gh-ext-simba-hx