Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-jsikorski committed Mar 11, 2024
1 parent d95501f commit 2277f88
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ features = ["development"]

[tool.hatch.envs.integration.scripts]
test = ["pytest -m integration --snapshot-warn-unused"]
test_win = ["pytest -m integration tests_integration/test_package.py::TestPackage::test_package_from_github -vv"]

[[tool.hatch.envs.local.matrix]]
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
Expand Down
8 changes: 0 additions & 8 deletions src/snowflake/cli/plugins/snowpark/package_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@ def install_packages(
package_name, RequirementType.PACKAGE
)

log.warning(
"Dependencies: %s", [req.requirement.name for req in dependencies]
) # TODO: delete debug log

if pip_install_result != 0:
log.info(pip_failed_msg.format(pip_install_result))
return False, None
Expand All @@ -169,10 +165,6 @@ def install_packages(
dependencies,
second_chance_results.snowflake if second_chance_results else None,
)
log.warning(
"Dependencies to be packed: %s",
[req.requirement.name for req in dependencies_to_be_packed],
) # TODO: delete debug log

log.info("Checking to see if packages have native libraries...")

Expand Down
8 changes: 2 additions & 6 deletions src/snowflake/cli/plugins/snowpark/venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,9 @@ def _get_dependencies(package: Requirement):
requirement=package, files=files, dependencies=requires
)

log.warning( # TODO: change back to debug
log.debug(
"Checking package %s, with dependencies: %s", package.name, requires
)
log.warning(installed_packages)

for package in requires:
_get_dependencies(Requirement.parse_line(package))
Expand All @@ -126,8 +125,7 @@ def _get_installed_packages_metadata(self):

def get_pip_inspect(self) -> Dict:
result = self.run_python(["-m", "pip", "inspect", "--local"])
log.warning("Result of pip inspect:")
log.warning(result) # TODO: remove this calls

if result.returncode == 0:
return json.loads(result.stdout)
else:
Expand All @@ -142,8 +140,6 @@ def _parse_info(self, package_name: str, info_type: PackageInfoType) -> List[str
f"from importlib.metadata import {info_type.value}; print({info_type.value}('{package_name}'))",
]
)
log.warning("Result of: print(%s(%s))", info_type.value, package_name)
log.warning(info) # TODO remove this call
if info.returncode != 0:
return []

Expand Down

0 comments on commit 2277f88

Please sign in to comment.