Disable symlink test on Windows

snowflakedb · Jul 11, 2024 · 5f4d4c4 · 5f4d4c4
1 parent d67c910
commit 5f4d4c4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/tests/nativeapp/codegen/snowpark/test_python_processor.py b/tests/nativeapp/codegen/snowpark/test_python_processor.py
@@ -37,9 +37,7 @@
 
 from tests.nativeapp.utils import assert_dir_snapshot, create_native_app_project_model
 from tests.testing_utils.files_and_dirs import pushd, temp_local_dir
-
-# if IS_WINDOWS:
-#     pytest.skip("Requires further refactor to work on Windows", allow_module_level=True)
+from tests_common import IS_WINDOWS
 
 PROJECT_ROOT = Path("/path/to/project")
 
@@ -275,6 +273,9 @@ def test_edit_setup_script_with_exec_imm_sql_noop(os_agnostic_snapshot):
 
 
 def test_edit_setup_script_with_exec_imm_sql_symlink(os_agnostic_snapshot):
+    if IS_WINDOWS:
+        pytest.skip("Symlinks on Windows are restricted to Developer mode or admins")
+
     manifest_contents = dedent(
         f"""\
         manifest_version: 1

diff --git a/tests/test_logs.py b/tests/test_logs.py
@@ -206,10 +206,6 @@ def test_log_files_permissions(setup_config_and_logs):
     if IS_WINDOWS:
         pytest.skip("Permissions for new files aren't strict in Windows")
 
-    original_mask = os.umask(0o000)
-    try:
-        with setup_config_and_logs(save_logs=True) as logs_path:
-            print_log_messages()
-            assert_file_permissions_are_strict(_get_logs_file(logs_path))
-    finally:
-        os.umask(original_mask)
+    with setup_config_and_logs(save_logs=True) as logs_path:
+        print_log_messages()
+        assert_file_permissions_are_strict(_get_logs_file(logs_path))