Correctly handle read-only files when cleaning up in `snow app list-t…

…emplates` (#1138)

src/snowflake/cli/plugins/nativeapp/commands.py

@@ -89,6 +89,8 @@ def app_list_templates(**options) -> CommandResult:
     Prints information regarding the official templates that can be used with snow app init.
     """
     with SecurePath.temporary_directory() as temp_path:
+        from git import rmtree as git_rmtree
+
         repo = shallow_git_clone(OFFICIAL_TEMPLATES_GITHUB_URL, temp_path.path)
 
         # Mark a directory as a template if a project definition jinja template is inside
@@ -113,6 +115,10 @@ def app_list_templates(**options) -> CommandResult:
             )
         )
 
+        # proactively clean up here to avoid permission issues on Windows
+        repo.close()
+        git_rmtree(temp_path.path)
+
         return CollectionResult(result)
 
 

tests_integration/nativeapp/test_templates.py

@@ -1,12 +1,18 @@
 import pytest
-from snowflake.connector.compat import IS_WINDOWS
 
 
 @pytest.mark.integration
-@pytest.mark.skipif(IS_WINDOWS, reason="Permissions issue on Windows")
-def test_list_templates_no_options_success(runner, snapshot):
+def test_list_templates_no_options_success(runner):
     args = ["app", "list-templates"]
-    result = runner.invoke(args)
+    result = runner.invoke_json(args)
 
     assert result.exit_code == 0
-    assert result.output == snapshot
+    templates = result.json
+    assert len(templates) > 0
+
+    # Check that the basic templates are present, but explicitly avoid checking for an
+    # exact list so that adding new templates won't break the tests.
+    all_template_names = [t["template"] for t in templates]
+    assert "basic" in all_template_names
+    assert "streamlit-java" in all_template_names
+    assert "streamlit-python" in all_template_names