Skip to content

Commit

Permalink
SNOW-1055755: windows build debug - ...wix util schema update - min t…
Browse files Browse the repository at this point in the history
…est 4
  • Loading branch information
sfc-gh-mraba committed Sep 10, 2024
1 parent d149050 commit 912d857
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
4 changes: 2 additions & 2 deletions scripts/packaging/win/build_snowflake_cli.bat
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ REM Build MSI-installer
cd ..\..
dir /r .
REM Generate wxs file for Wix
python.exe -m hatch -e packaging run ^
python scripts\packaging\win\wxs_builder.py
REM python.exe -m hatch -e packaging run ^
REM python scripts\packaging\win\wxs_builder.py

candle ^
-dSnowflakeCLIVersion=%CLI_VERSION% ^
Expand Down
13 changes: 6 additions & 7 deletions scripts/packaging/win/snowflake_cli.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@
<Property Id="ARPURLINFOABOUT" Value="https://snowflake.com/" />
<Property Id="ApplicationFolderName" Value="Snowflake CLI" />
<Property Id="WixAppFolder" Value="WixUISupportPerUser" />
<StandardDirectory Id="ProgramFiles6432Folder">
<Directory
Id="INSTALLFOLDER"
Name="!(bind.Property.Manufacturer) !(bind.Property.ProductName)"
/>
</StandardDirectory>
</Package>
<StandardDirectory Id="ProgramFiles6432Folder">
<Directory Id="INSTALLFOLDER" Name="!(bind.Property.ProductName)" />
</StandardDirectory>
<Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER" />
<UIRef Id="WixUI_InstallDir" />
</Package>
</Wix>

0 comments on commit 912d857

Please sign in to comment.