Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into jsikorski/streamlit_e…
Browse files Browse the repository at this point in the history
…ntities

# Conflicts:
#	src/snowflake/cli/_plugins/streamlit/streamlit_entity.py
  • Loading branch information
sfc-gh-jsikorski committed Dec 12, 2024
2 parents a02d7c5 + 5a3e36e commit f5b1a54
Show file tree
Hide file tree
Showing 39 changed files with 3,542 additions and 224 deletions.
8 changes: 8 additions & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,17 @@
## Deprecations

## New additions
* Add Release Directives support by introducing the following commands:
* `snow app release-directive list`
* `snow app release-directive set`
* `snow app release-directive unset`
* Add support for release channels feature in native app version creation/drop.
* `snow app version create` now returns version, patch, and label in JSON format.

## Fixes and improvements
* Fixed crashes with older x86_64 Intel CPUs.
* Fixed inability to add patches to lowercase quoted versions
* Fixes label being set to blank instead of None when not provided.

# v3.2.0

Expand Down
9 changes: 8 additions & 1 deletion src/snowflake/cli/_plugins/nativeapp/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
from snowflake.cli._plugins.nativeapp.entities.application_package import (
ApplicationPackageEntityModel,
)
from snowflake.cli._plugins.nativeapp.release_directive.commands import (
app as release_directives_app,
)
from snowflake.cli._plugins.nativeapp.sf_facade import get_snowflake_facade
from snowflake.cli._plugins.nativeapp.v2_conversions.compat import (
find_entity,
Expand Down Expand Up @@ -67,6 +70,7 @@
help="Manages a Snowflake Native App",
)
app.add_typer(versions_app)
app.add_typer(release_directives_app)

log = logging.getLogger(__name__)

Expand Down Expand Up @@ -358,7 +362,10 @@ def app_validate(
if cli_context.output_format == OutputFormat.JSON:
return ObjectResult(
package.get_validation_result(
use_scratch_stage=True, interactive=False, force=True
action_ctx=ws.action_ctx,
use_scratch_stage=True,
interactive=False,
force=True,
)
)

Expand Down
4 changes: 4 additions & 0 deletions src/snowflake/cli/_plugins/nativeapp/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@
OWNER_COL = "owner"
VERSION_COL = "version"
PATCH_COL = "patch"
CHANNEL_COL = "release_channel_name"
AUTHORIZE_TELEMETRY_COL = "authorize_telemetry_event_sharing"

INTERNAL_DISTRIBUTION = "internal"
EXTERNAL_DISTRIBUTION = "external"

DEFAULT_CHANNEL = "DEFAULT"
DEFAULT_DIRECTIVE = "DEFAULT"
Loading

0 comments on commit f5b1a54

Please sign in to comment.