Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect snapshots #1144

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix incorrect snapshots #1144

merged 1 commit into from
May 29, 2024

Conversation

sfc-gh-bdufour
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour commented May 29, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • N/A I've added or updated automated unit tests to verify correctness of my new code.
  • N/A I've added or updated integration tests to verify correctness of my new code.
  • N/A I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • N/A I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

I just noticed that some of the existing snapshots are incorrect and cause some errors when running locally (somehow the run isn't considered a failure, but I'm not sure why...). In any case fixing them is necessary.

@sfc-gh-bdufour sfc-gh-bdufour force-pushed the bdufour-fix-snapshots branch from 1a63698 to 6d088fe Compare May 29, 2024 16:32
@sfc-gh-bdufour sfc-gh-bdufour marked this pull request as ready for review May 29, 2024 16:42
@sfc-gh-bdufour sfc-gh-bdufour requested a review from a team as a code owner May 29, 2024 16:42
sfc-gh-cgorrie
sfc-gh-cgorrie approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-cgorrie sfc-gh-cgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-bdufour sfc-gh-bdufour merged commit 7709acf into main May 29, 2024
22 checks passed
@sfc-gh-bdufour sfc-gh-bdufour deleted the bdufour-fix-snapshots branch May 29, 2024 17:01
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-bdufour
Fix incorrect snapshots (#1144)
455a5d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-cgorrie sfc-gh-cgorrie sfc-gh-cgorrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bdufour @sfc-gh-cgorrie