Fix missing grants to run native app integ tests locally #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
approved these changes
May 31, 2024
sfc-gh-bdufour
force-pushed
the
bdufour-na-integ-tests
branch
from
307a769 to
4be8600
Compare
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
The integ test setup script is missing a few grants to make native app tests pass. Also fixing a bug spotted by @sfc-gh-cgorrie that makes the script non re-entrant.
Testing
Executed the new queries and verified that the integ tests for the
nativeappfolder are now able to run successfully.