Snow 1533042 create error handling fix #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELEASE-NOTES.md
Outdated
| @@ -32,6 +32,7 @@ | |||
| * Added support for user stages in stage execute command | |||
| * Added support for user stages in stage and git copy commands | |||
| * Improved support for quoted identifiers in snowpark commands. | |||
| * `snow object create` message returns meaningful error if connection database is not defined. | |||
There was a problem hiding this comment.
Remember to move it to v2.6.1
|
|
||
| raise CannotDetermineCreateURLException( | ||
| f"Create operation for type {object_type} is not supported. Try using `sql -q 'CREATE ...'` command." | ||
| ) |
There was a problem hiding this comment.
This is for later, we should consider whether we need so many requests.
sfc-gh-astus
approved these changes
Jul 15, 2024
sfc-gh-pczajka
added a commit
that referenced
this pull request
Jul 15, 2024
* Fix error messages * Fix error handling in rest_api * Add tests * refactor * update release notes * fix comment * move release note to v2.6.1:
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Fix error messages * Fix error handling in rest_api * Add tests * refactor * update release notes * fix comment * move release note to v2.6.1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
More detailed error detection while determining CREATE endpoints url