Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional subdirectory for stage in application package #1916

Merged
merged 52 commits into from
Jan 15, 2025
Merged

Add optional subdirectory for stage in application package #1916

merged 52 commits into from
Jan 15, 2025

Conversation

sfc-gh-pjafari
Copy link
Contributor

@sfc-gh-pjafari sfc-gh-pjafari commented Dec 3, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Added an optional stage_subdirectory to the application package.
This change means that the root of the stage is no longer the assumed path to finding the artifacts and the manifest.yml. If specified, the application package will only ever operate on stage/stage_subdirectory. This includes deploy, diff, and version create.

For detailed information on how this affects each command, if specified, refer to the design document.

@sfc-gh-pjafari sfc-gh-pjafari changed the title Pj subartifacts subdirs subdirs Dec 3, 2024
@sfc-gh-pjafari sfc-gh-pjafari mentioned this pull request Dec 4, 2024
Merged
8 tasks
@sfc-gh-pjafari sfc-gh-pjafari force-pushed the pj-subartifacts-subdirs branch from 8347118 to b94bad5 Compare December 18, 2024 15:04
sfc-gh-astus
sfc-gh-astus previously approved these changes Jan 13, 2025
View reviewed changes
@sfc-gh-pjafari sfc-gh-pjafari enabled auto-merge (squash) January 13, 2025 16:26
sfc-gh-astus
sfc-gh-astus previously approved these changes Jan 14, 2025
View reviewed changes
@sfc-gh-pjafari sfc-gh-pjafari merged commit a33c944 into main Jan 15, 2025
20 checks passed
@sfc-gh-pjafari sfc-gh-pjafari deleted the pj-subartifacts-subdirs branch January 15, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka left review comments

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour left review comments

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-pjafari @sfc-gh-astus @sfc-gh-bdufour @sfc-gh-melnacouzi @sfc-gh-pczajka