Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize names used in the artifact processor pipeline #1933

Open
wants to merge 9 commits into
base: features/unification-artifacts
Choose a base branch
from
+5,954 −2,681
Open

Generalize names used in the artifact processor pipeline #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4dd42c1
Added glob support for snowpark and streamlit (#1862)
sfc-gh-astus Nov 18, 2024
9211c07
Fix broken v1 to v2 test on the feature branch (#1876)
sfc-gh-bdufour Nov 21, 2024
47f6b13
Moved native app artifacts logic to common API (#1877)
sfc-gh-bdufour Nov 25, 2024
6d14190
Move PathMapping and ProcessorMapping out of native app logic (#1899)
sfc-gh-bdufour Nov 27, 2024
6281e35
Fix rebase issues in feature/unification-artifacts (#1932)
sfc-gh-bdufour Dec 9, 2024
9cb87b3
Fixes to imports following rebase
sfc-gh-bdufour Dec 9, 2024
5a47d22
Generalized names for processor compiler and context
sfc-gh-bdufour Dec 6, 2024
d7ca988
Completed renaming
sfc-gh-bdufour Dec 6, 2024
17e4b2a
Fix following rebase
sfc-gh-bdufour Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@
**/__snapshots__/ @snowflakedb/snowcli @snowflakedb/nade
**/test_data @snowflakedb/snowcli @snowflakedb/nade
**/testing_utils/ @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/artifacts/ @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/metrics.py @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/project/definition_conversion.py @snowflakedb/snowcli @snowflakedb/nade
src/snowflake/cli/api/utils/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/artifacts/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/metrics/ @snowflakedb/snowcli @snowflakedb/nade
tests/api/test_metrics.py @snowflakedb/snowcli @snowflakedb/nade
tests/api/utils/ @snowflakedb/snowcli @snowflakedb/nade
tests_common/__init__.py @snowflakedb/snowcli @snowflakedb/nade
tests_common/conftest.py @snowflakedb/snowcli @snowflakedb/nade
tests_common/deflake.py @snowflakedb/snowcli @snowflakedb/nade
Expand Down
2 changes: 2 additions & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
* `--follow`: Stream logs in real-time.
* `--follow-interval`: Set custom polling intervals during log streaming.
* `snow connection add` supports `--no-interactive` flag to skip interactive prompts.
* Added support for glob pattern in artifact paths in snowflake.yml for Streamlit.
* Added support for glob pattern in artifact paths in snowflake.yml for Snowpark, requires ENABLE_SNOWPARK_GLOB_SUPPORT feature flag.

## Fixes and improvements
* `snow --info` callback returns information about `SNOWFLAKE_HOME` variable.
Expand Down
4 changes: 2 additions & 2 deletions .../cli/_plugins/nativeapp/bundle_context.py → ...s/nativeapp/artifact_processor_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
List,
)

from snowflake.cli.api.project.schemas.v1.native_app.path_mapping import PathMapping
from snowflake.cli.api.project.schemas.entities.common import PathMapping


@dataclass
class BundleContext:
class ArtifactProcessorContext:
package_name: str
Comment on lines +25 to 26
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: this will be refactored next

artifacts: List[PathMapping]
project_root: Path
Expand Down
Loading
Loading