Add streamlit entities #1934
Merged
Add streamlit entities #1934
+416
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
015c955 to
3d36227
Compare
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
33999ec to
6bdb1af
Compare
…ntities # Conflicts: # tests/streamlit/__snapshots__/test_commands.ambr # tests/test_data/projects/example_streamlit_v2/snowflake.yml
| from snowflake.cli.api.entities.common import EntityBase | ||
| from snowflake.cli._plugins.workspace.context import ActionContext | ||
| from snowflake.cli.api.entities.common import EntityBase, get_sql_executor | ||
| from snowflake.connector.cursor import SnowflakeCursor | ||
|
|
||
|
|
||
| class StreamlitEntity(EntityBase[StreamlitEntityModel]): |
There was a problem hiding this comment.
I added a temporary mock implementation of StreamlitEntity for composability with Native Apps in #1856.
The fake logic will be replaced by your PR, but please take a look at the proposed ApplicationPackageChildInterface contract.
There was a problem hiding this comment.
Renamed some methods to allign it with your interface.
Bundle and deploy actions are left intact, as they will have to be heavily remodeled, after introducing project-wide bundle map and other changes to output files management
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
255ec61 to
6ccfdc8
Compare
…ntities # Conflicts: # src/snowflake/cli/_plugins/streamlit/streamlit_entity.py
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
07ccf39 to
c6fe394
Compare
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
2 times, most recently
from
9de1ca8 to
83af4d1
Compare
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
83af4d1 to
46f4447
Compare
sfc-gh-gbloom
previously approved these changes
Dec 16, 2024
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
cb2d9fe to
423eff7
Compare
sfc-gh-pczajka
previously approved these changes
Dec 18, 2024
Co-authored-by: Guy Bloom <guy.bloom@snowflake.com>
…age.py Co-authored-by: Guy Bloom <guy.bloom@snowflake.com>
sfc-gh-jsikorski
force-pushed
the
jsikorski/streamlit_entities
branch
from
ab412a9 to
619288f
Compare
sfc-gh-gbloom
approved these changes
Dec 19, 2024
sfc-gh-pczajka
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added streamlit entity outline for introducing composability in PRDF v2