[SNOW-1747456] Remove side effects from command registration #1945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
CliAppFactory
, which wraps all callback definitions. Thanks to that, callbacks and commands are not registered globally but only within an instance ofCliAppFactory
. The factory exposescreate_or_get_app
method.AppContextHolder
in favour ofget_click_context
method exposed byCliAppFactory
. Click context was and still is needed in tests traversing command tree (like docs generation tests).commands_registration_with_callbacks.py
.before
callback wrapper. It was used to invoke commands registration as soon as possible but IMO it's not needed to do it as soon as possible and we can invoke registration fromcommands_registration_callback
after processing all eager CLI options (what we did anyway but previously only as a fallback, which wasn't needed).