Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1733048 Add internal app data to cli #1971

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

sfc-gh-pczajka
Copy link
Contributor

@sfc-gh-pczajka sfc-gh-pczajka commented Jan 7, 2025

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Add internal application data to CLI. This change is hidden behind a feature flag to avoid BCR.

The change enables user to set AUTHENTICATION POLICY restricting access to CLI only (not along other drivers)

Manual testing checked on MacOS (CLI) vs preprod and po52878.snowflakecomputing.com snowflake distributions:

  1. create AUTH POLICY restricting access to SNOWFLAKE_CLI
  2. check that snow sql "select 1" works only when the feature flag is enabled
  3. create AUTH POLICY restricting access to DRIVERS
  4. check that snow sql "select 1" works only when the feature flag is disabled/not defined

@sfc-gh-pczajka sfc-gh-pczajka requested a review from a team as a code owner January 7, 2025 15:37
@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) January 8, 2025 11:38
@sfc-gh-pczajka sfc-gh-pczajka merged commit 21d864a into main Jan 8, 2025
20 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-1733048-add-internal-app-data-to-CLI branch January 8, 2025 12:57
@sfc-gh-pczajka sfc-gh-pczajka mentioned this pull request Jan 9, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants