Add --from-stage option to version create #1973
Merged
+184
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-melnacouzi
force-pushed
the
melnacouzi-add-from-stage-to-version-create
branch
2 times, most recently
from
ab0a5c2 to
85865f7
Compare
| # then do not re-deploy the artifacts or touch the stage | ||
| if from_stage: | ||
| # verify package exists: | ||
| show_obj_row = self.get_existing_app_pkg_info() |
There was a problem hiding this comment.
nit: we can directly check self.get_existing_app_pkg_info() in the if statement
| @@ -25,6 +25,7 @@ | |||
| * `snow app release-directive set` | |||
| * `snow app release-directive unset` | |||
| * `snow app version create` now returns version, patch, and label in JSON format. | |||
| * Add `--from-stage` flag to `snow app version create` to allow version creation from the content of the stage without re-syncing to the stage. | |||
There was a problem hiding this comment.
Out of curiosity, what does "re-syncing to the stage" mean?
There was a problem hiding this comment.
uploading files to the stage from local workspace.
| @@ -1923,6 +1923,13 @@ | |||
| | untracked or stages | | |||
| | files in git. Default: | | |||
| | unset. | | |||
| | --from-stage When enabled, the | | |||
There was a problem hiding this comment.
I'm curious what is this file?
There was a problem hiding this comment.
It contains snapshots from all the commands through unit tests - it is auto-generated, and helps verify that the command output changes (--help) are as expected.
sfc-gh-melnacouzi
force-pushed
the
melnacouzi-add-from-stage-to-version-create
branch
from
6cbdb1c to
889e033
Compare
sfc-gh-ahelal
approved these changes
Jan 9, 2025
sfc-gh-melnacouzi
deleted the
melnacouzi-add-from-stage-to-version-create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add --from-stage option to version create
When
--from-stageis provided,snow app version create --from-stagewill create a version from the content of the stage directly without resyncing the local files to the stage.