Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1874231] Pinning click to 8.1.7 as temporary workaround to unblock tests failing by recent changes in click #1977

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[SNOW-1874231] Pinning click to 8.1.7 as temporary workaround to unblock tests failing by recent changes in click #1977

merged 1 commit into from
Jan 8, 2025

Conversation

sfc-gh-pjob
Copy link
Contributor

@sfc-gh-pjob sfc-gh-pjob commented Jan 8, 2025 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Pinning click version to 8.1.7 because our integration tests currently fail on 8.1.8. Typer uses click>=8.0.6 requirement. We'll continue debugging of issues with 8.1.8 and remove the pin later.

@sfc-gh-pjob sfc-gh-pjob changed the title [SNOW-1874231] Temporary workaround to unblock tests failing by recent changes in click [SNOW-1874231] Pinning click to 8.1.7 as temporary workaround to unblock tests failing by recent changes in click Jan 8, 2025
@sfc-gh-pjob sfc-gh-pjob mentioned this pull request Jan 8, 2025
Closed
8 tasks
@sfc-gh-pjob sfc-gh-pjob marked this pull request as ready for review January 8, 2025 12:08
@sfc-gh-pjob sfc-gh-pjob requested a review from a team as a code owner January 8, 2025 12:08
@sfc-gh-pjob sfc-gh-pjob merged commit 9f47aa3 into main Jan 8, 2025
20 checks passed
@sfc-gh-pjob sfc-gh-pjob deleted the pjob/SNOW-1874231-fix-plugin-tests branch January 8, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pjob @sfc-gh-astus