SNOW-1011774: Adding scope filter (--in) to snow object list #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
3 times, most recently
from
8938f6e to
6bc7ab9
Compare
sfc-gh-davwang
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus,
sfc-gh-mraba and
sfc-gh-pczajka
as code owners
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
6bc7ab9 to
0eaf7d5
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
0eaf7d5 to
87c88bc
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
bab8cf8 to
e3e8a40
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
e3e8a40 to
d279164
Compare
sfc-gh-davwang
commented
Feb 1, 2024
sfc-gh-davwang
commented
Feb 1, 2024
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
d279164 to
a5f0ce8
Compare
sfc-gh-astus
reviewed
Feb 6, 2024
sfc-gh-astus
reviewed
Feb 6, 2024
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
a5f0ce8 to
aac43ea
Compare
… implementation to use a tuple (<scope>, <name>) instead of parsing <scope>=<name> from a string.
… of typer CLI support for optional tuples
…s for 'object list' with scope
…with services. Test cleanup.
…ckException is raised
sfc-gh-davwang
force-pushed
the
SNOW-1011774-object-list-filter
branch
from
aac43ea to
4a0d318
Compare
sfc-gh-astus
approved these changes
Feb 6, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* SNOW-1011774: Adding generic '--in' option to snow object list (not yet implemented) * SNOW-1011774: Renaming InOption to ScopeOption for semantics. Changed implementation to use a tuple (<scope>, <name>) instead of parsing <scope>=<name> from a string. * SNOW-1011774: Writing tests for 'list --in * SNOW-1011774: Fixing type of scope option for 'object list' to be optional. * SNOW-1011774: Changing default for '--in' to (None, None) due to lack of typer CLI support for optional tuples * SNOW-1011774: Adding unit tests for _scope_callback, integration tests for 'object list' with scope * SNOW-1011774: Adding validation that compute-pool scope is only used with services. Test cleanup. * SNOW-1011774: Adding message checking when testing that a generic ClickException is raised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added an option called 'scope' ('--in') to
snow object listthat allows users to filter by scope (database, schema, compute pool for services, application for application roles, etc.)Example usage:
Number of Inputs Validation via Typer:
