SNOW-1011766: Added 'snow spcs image-repository url <repo_name>' command #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
dd6509c to
e4ba8bd
Compare
sfc-gh-davwang
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus,
sfc-gh-mraba and
sfc-gh-pczajka
as code owners
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
416f3f4 to
d5241ab
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
cb39f19 to
a26a7e5
Compare
sfc-gh-davwang
commented
Feb 1, 2024
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
2 times, most recently
from
39c4329 to
8a35760
Compare
sfc-gh-davwang
requested review from
sfc-gh-bgoel,
sfc-gh-cgorrie,
sfc-gh-bdufour and
sfc-gh-melnacouzi
as code owners
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
cbe9970 to
b3c6758
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
b3c6758 to
4ec757e
Compare
sfc-gh-davwang
commented
Feb 6, 2024
sfc-gh-davwang
commented
Feb 6, 2024
sfc-gh-yiwang
previously approved these changes
Feb 6, 2024
sfc-gh-davwang
commented
Feb 6, 2024
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
a614a20 to
a093314
Compare
sfc-gh-davwang
commented
Feb 7, 2024
| self.check_database_and_schema() | ||
| return self._execute_query(query) | ||
| return self._execute_query(query, **kwargs) | ||
|
|
There was a problem hiding this comment.
allows you to pass cursor_class with _execute_schema_query
sfc-gh-davwang
commented
Feb 7, 2024
sfc-gh-astus
reviewed
Feb 7, 2024
| results = result_set.fetchall() | ||
|
|
||
| colored_repo_name = click.style(f"'{repo_name}'", fg="green") |
There was a problem hiding this comment.
Is this color needed? It only cause problems with equals check
There was a problem hiding this comment.
I think it has marginal improvement for UI but testability is probably more important. Good point.
…nd along with unit and integration tests
…full flow of create repo, show repos, get repo url
…t_repository_url_cli
… escape_like_pattern
…pository name for getting image repository url
…s as image repositories do not support quoted identifiers
sfc-gh-davwang
force-pushed
the
SNOW-1011766-get-repository-url
branch
from
7dd3b88 to
9658712
Compare
sfc-gh-astus
approved these changes
Feb 7, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
…and (#708) * SNOW-1011766: Added 'snow spcs image-repository url <repo_name' command along with unit and integration tests * SNOW-1011766: Update release notes * SNOW-1011766: Updating integration tests for repository url to cover full flow of create repo, show repos, get repo url * SNOW-1011766: Removing unnecessary connection parameters from test_get_repository_url_cli * SNOW-1011766: Fixed typo in escape_like_pattern, wrote unit tests for escape_like_pattern * SNOW-1011766: Code refactor and dealing with possibility of quoted repository name for getting image repository url * SNOW-1011766: Code clean * SNOW-1011766: Adding more unit tests for get_repository_url * SNOW-1011766: Removing parts of code that deal with quoted identifiers as image repositories do not support quoted identifiers * SNOW-1011766: Removing unnecessary URL processing * fixup * SNOW-1011766: Adding comment explaining usage of escape_like_pattern * SNOW-1011766: Making error message for no image repository found more informative * SNOW-1011766: Removing error coloring that interfered with equality checks in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added a new convenience command of
snow spcs image-repository urlthat returns the full URL given a repository name. Note that image repositories do not allow for quoted identifiers, so I have added checks that repository name inputs must be unquoted identifiers.Example Usage
