SNOW-1011769: Convenience command 'spcs image-registry url' to get registry url based on current account. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-davwang
force-pushed
the
SNOW-1011769-get-registry-url
branch
from
8c35384 to
4a9f3d1
Compare
sfc-gh-davwang
force-pushed
the
SNOW-1011769-get-registry-url
branch
from
4a9f3d1 to
654ac02
Compare
sfc-gh-davwang
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus,
sfc-gh-mraba and
sfc-gh-pczajka
as code owners
sfc-gh-yiwang
previously approved these changes
Feb 1, 2024
sfc-gh-davwang
commented
Feb 1, 2024
sfc-gh-davwang
force-pushed
the
SNOW-1011769-get-registry-url
branch
3 times, most recently
from
c47169d to
57261f9
Compare
7 tasks
sfc-gh-astus
reviewed
Feb 7, 2024
…deal with colored output well)
…etting registry URL
sfc-gh-davwang
force-pushed
the
SNOW-1011769-get-registry-url
branch
from
57261f9 to
7954202
Compare
sfc-gh-astus
previously approved these changes
Feb 7, 2024
sfc-gh-astus
approved these changes
Feb 7, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
…gistry url based on current account. (#715) * SNOW-1011769: Adding 'spcs image-registry url' command. * SNOW-1011769: Fixing integration tests (seems like snapshot does not deal with colored output well) * SNOW-1011769: Updating error message for no repositories found when getting registry URL * SNOW-1011769: Updating test output * SNOW-1011769: Use urlparse to get registry url from repo url. Improving error name * SNOW-1011769: Updating tests to use row_from_snowflake_session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added a new command under
spcs image-registrycalledurlthat prints the image registry url as long as the current role can view at least one image repository. This matches the normal workflow where users will create an image repository, then get the image registry url.Usage (error message has been updated but gist is same):
