Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SnowTyper together with telemetry #731

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Add SnowTyper together with telemetry #731

merged 6 commits into from
Feb 6, 2024

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

To add telemetry we need place to place a callback either before or post execute. This PR adds SnowTyper that implements this idea. This PR applies the new typer instance to connection and sql commands. In follow up PRs we should adjust remaining command.

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review February 5, 2024 10:57
sfc-gh-pjob
sfc-gh-pjob reviewed Feb 5, 2024
View reviewed changes
src/snowflake/cli/app/main_typer.py Outdated Show resolved Hide resolved
src/snowflake/cli/api/utils/error_handling.py Outdated Show resolved Hide resolved
src/snowflake/cli/app/telemetry.py Show resolved Hide resolved
tests/test_connection.py Show resolved Hide resolved
tests/test_snow_typer.py Outdated Show resolved Hide resolved
sfc-gh-mraba
sfc-gh-mraba previously approved these changes Feb 6, 2024
View reviewed changes
src/snowflake/cli/plugins/connection/commands.py Show resolved Hide resolved
src/snowflake/cli/api/commands/snow_typer.py Outdated Show resolved Hide resolved
sfc-gh-mraba
sfc-gh-mraba previously approved these changes Feb 6, 2024
View reviewed changes
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) February 6, 2024 15:06
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 23b2c2f into main Feb 6, 2024
17 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the add-telemetry branch February 6, 2024 15:08
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-turbaszek
Add SnowTyper together with telemetry (#731)
072a9c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus left review comments

@sfc-gh-mraba sfc-gh-mraba sfc-gh-mraba approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski Awaiting requested review from sfc-gh-jsikorski

@sfc-gh-pczajka sfc-gh-pczajka Awaiting requested review from sfc-gh-pczajka

@sfc-gh-pjob sfc-gh-pjob Awaiting requested review from sfc-gh-pjob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-turbaszek @sfc-gh-astus @sfc-gh-pjob @sfc-gh-mraba