Snow 1038392 validation of plugin enabled type #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus and
sfc-gh-mraba
as code owners
sfc-gh-jsikorski
requested changes
Feb 5, 2024
| from snowflake.cli.api.plugins.plugin_config import PluginConfig | ||
|
|
||
|
|
||
| def _assert_config_enabled_value_is_bool(value, plugin_name) -> None: |
There was a problem hiding this comment.
Maybe lets name it _assert_value_is_bool as we can pass any value here
sfc-gh-jsikorski
approved these changes
Feb 6, 2024
sfc-gh-pczajka
deleted the
SNOW-1038392-validation-of-plugin-enabled-type
branch
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Add plugin config enabled type validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add validation of "enabled" value from plugins section of config.toml