Create a pattern for drilling down to a single "show objects like" row #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cgorrie
requested review from
sfc-gh-bgoel,
sfc-gh-bdufour,
sfc-gh-melnacouzi,
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus,
sfc-gh-mraba and
sfc-gh-pczajka
as code owners
sfc-gh-bgoel
reviewed
Feb 7, 2024
sfc-gh-cgorrie
force-pushed
the
refactor-get-object-row
branch
from
16cb9a3 to
2bc5392
Compare
sfc-gh-cgorrie
force-pushed
the
refactor-get-object-row
branch
from
d69854a to
2bcc62e
Compare
sfc-gh-davwang
previously approved these changes
Feb 8, 2024
|
if you're amenable to including it, here's a PR to use your new function in image_registry/manager: #755. Feel free to merge it in yourself if you approve. |
sfc-gh-astus
previously approved these changes
Feb 9, 2024
….. LIKE ... based on object name from NativeAppManager and ImageRepositoryManager to a mixin.
sfc-gh-cgorrie
force-pushed
the
refactor-get-object-row
branch
from
998e3fe to
0d81de0
Compare
sfc-gh-bgoel
approved these changes
Feb 9, 2024
sfc-gh-bdufour
approved these changes
Feb 9, 2024
Comment on lines
+147
to
+169
| def show_specific_object( | ||
| self, | ||
| object_type_plural: str, | ||
| unqualified_name: str, | ||
| name_col: str = "name", | ||
| in_clause: str = "", | ||
| ) -> Optional[dict]: | ||
| """ | ||
| Executes a "show <objects> like" query for a particular entity with a | ||
| given (unqualified) name. This command is useful when the corresponding | ||
| "describe <object>" query does not provide the information you seek. | ||
| """ | ||
| show_obj_query = f"show {object_type_plural} like {identifier_to_show_like_pattern(unqualified_name)} {in_clause}".strip() | ||
| show_obj_cursor = self._execute_query( # type: ignore | ||
| show_obj_query, cursor_class=DictCursor | ||
| ) | ||
| if show_obj_cursor.rowcount is None: | ||
| raise SnowflakeSQLExecutionError(show_obj_query) | ||
| show_obj_row = find_first_row( | ||
| show_obj_cursor, | ||
| lambda row: row[name_col] == unquote_identifier(unqualified_name), | ||
| ) | ||
| return show_obj_row |
There was a problem hiding this comment.
Why it's there not in ObjectManager?
There was a problem hiding this comment.
To me, that's a different layer. My mental model of layers:
- command "spec" / app layer (i.e.
commands.py) - command implementation layer (i.e. managers; e.g.
ObjectManager.py) - utility layer (e.g.
utils/*.py, andSqlExecutionMixin)
Suppose we were to put it in ObjectManager. Other managers that want to use it would have to instantiate an ObjectManager(), then call this. Right now there's no args for the constructor but I'm not sure we can count on that going forward given the design (e.g. if we ever needed to support multiple concurrent connections). So this felt like the cleanest place to put it, aside from the architectural concern noted above.
sfc-gh-turbaszek
approved these changes
Feb 13, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
#748) * SNOW-1011766: Factoring out shared logic of getting a row from SHOW ... LIKE ... based on object name from NativeAppManager and ImageRepositoryManager to a mixin. * Adding identifier_to_show_like_pattern * move show_specific_object to SqlExecutionMixin * add test and remove TODO * CR review * using show_specific_object in image_repository.manager.get_repository_url (#755) --------- Co-authored-by: David Wang <d.wang@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Introduced
SqlExecutionMixin.show_specific_objectto share code between all the times we need toshow objects likein order to get more information about a particular entity.Original author: @sfc-gh-davwang