Add basic templating to snow sql #879
Conversation
sfc-gh-turbaszek
force-pushed
the
add-support-for-basic-sql-templating
branch
from
cb55c48 to
454ede4
Compare
| loader=loaders.FileSystemLoader(template_path.parent), | ||
| keep_trailing_newline=True, | ||
| undefined=StrictUndefined, | ||
| ) |
There was a problem hiding this comment.
This is being used in snow app init, which currently uses the regular jinja syntax {{}}. I think we can constrain it such that all client side rendering must have &{} only. I can change our templates to conform to that. WDYT?
There was a problem hiding this comment.
I don't agree, for example imagine creating a project for template that includes client side templating...
There was a problem hiding this comment.
Native app has custom client-side template logic now that uses the standard jinja2 syntax. We should likely also support the Snowflake CLI syntax, but we can't remove support for the current behaviour without risking breaking existing users. I do agree with Tomasz that the Snowflake CLI does make it easier for clients to mix their own client-side template with ours.
| # Using $ as sf variable and client side rendering | ||
| ("$&{ foo }", "$bar"), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
This is helpful, thank you!
sfc-gh-turbaszek
force-pushed
the
add-support-for-basic-sql-templating
branch
from
69d1542 to
916238b
Compare
| query: Optional[str], | ||
| file: Optional[Path], | ||
| std_in: bool, | ||
| data: Dict | None = None, |
There was a problem hiding this comment.
PEP604 make both syntaxes compatible. We don't have a common pattern in our code base.
There was a problem hiding this comment.
Python-Version: 3.10 What with 3.8 and 3.9?
There was a problem hiding this comment.
@sfc-gh-astus we already use it across the code base so this is nothing new. If we want to align to standard format (for example #1001 ) we should do so in other PR.
|
|
||
|
|
||
| def get_snowflake_cli_jinja_env(): | ||
| _random_block = "___very___unique___block___to___disable___logic___blocks___" |
There was a problem hiding this comment.
A unique block to disable logic blocks. We don't want to support {% for foo in bar %} syntax.
Pre-review checklist
Changes description
Add basic rendering of templates in SQL.